Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stm32 gpio driver #447

Merged
merged 1 commit into from
May 23, 2023
Merged

Update stm32 gpio driver #447

merged 1 commit into from
May 23, 2023

Conversation

UncleGrumpy
Copy link
Collaborator

Restores functionality to the stm32 gpio driver by updating mailbox message parsing to match updates to the the erlang and elixir drivers. Modifies the pin() type in both versions of the gpio driver to accommodate tuples used in the stm32 port.

Signed-off-by: Winford [email protected]

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Copy link
Collaborator

@fadushin fadushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue to address. I assume this change is needed because at one point I believe we may have changed the contract to include the reference

src/platforms/stm32/src/lib/gpiodriver.c Outdated Show resolved Hide resolved
@UncleGrumpy
Copy link
Collaborator Author

I assume this change is needed because at one point I believe we may have changed the contract to include the reference

Yes. That is exactly what happened, and why these changes are needed.

Restores functionality to the stm32 gpio driver by updating mailbox message
parsing to match updates to the the erlang and elixir drivers. Modifies the
`pin() type` in both versions of the gpio driver to accommodate tuples used
in the stm32 port.

Signed-off-by: Winford <[email protected]>
@bettio bettio merged commit a557047 into atomvm:master May 23, 2023
@UncleGrumpy UncleGrumpy deleted the stm32_gpio branch October 26, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants