Add ets:update_counter #1406
Open
Add ets:update_counter #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Sobkiewicz <[email protected]>
TheSobkiewicz
changed the title
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
from
0be618b to
4d64c65
Compare
bettio
requested changes
Dec 22, 2024
src/libAtomVM/ets.c
Outdated
| EtsErrorCode ets_update_counter(term ref, term key, term operation, term default_value, term *ret, Context *ctx) | ||
| { | ||
| struct EtsTable *ets_table = term_is_atom(ref) ? ets_get_table_by_name(&ctx->global->ets, ref, TableAccessWrite) : ets_get_table_by_ref(&ctx->global->ets, term_to_ref_ticks(ref), TableAccessWrite); | ||
| if (ets_table == NULL) { |
There was a problem hiding this comment.
Since the most likely outcome is a found table, I would do if (IS_NULL_PTR(ets_table)) { (that is a short hand of if (UNLIKELY(ets_table == NULL)) {).
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
from
8f58d8e to
7c5d166
Compare
Signed-off-by: Tomasz Sobkiewicz <[email protected]>
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
from
7c5d166 to
ed57a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Added support for ets:update_counter/3 and ets:update_counter/4.
https://www.erlang.org/docs/23/man/ets#update_counter-3
Based on:
#1405
Currently this solution doesn't support list of UpdateOp to update multiple counters.