Add sets module and maps:from_keys/2
#1226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
reviewed
Jul 7, 2024
bettio
force-pushed
the
add-sets-module
branch
2 times, most recently
from
c0a145f
to
162afd6
Compare
UncleGrumpy
reviewed
Jul 10, 2024
pguyot
reviewed
Jul 11, 2024
bettio
force-pushed
the
add-sets-module
branch
6 times, most recently
from
f90b827
to
6e2ae2d
Compare
Add missing free() in error condition, before raising out of memory error. Signed-off-by: Davide Bettio <[email protected]>
This function is heavily used from modules such as sets.
So maps such as `#{1 => [], 2 => []}` can be quickly created from a list
of keys.
Signed-off-by: Davide Bettio <[email protected]>
Code has been taken from github.com/erlang/otp/blob/master/lib/stdlib/src/sets.erl (main branch). Few changes have been made to match documentation format, and to make filter and map functions working with all erlang compiler versions we support. Tests for sets have been excluded on certain OTP versions since we use maps:from_keys that is available since OTP 24. Signed-off-by: Davide Bettio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sets module and required functions to make it work.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later