Fix C++ compilation #1158
Merged
Fix C++ compilation #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, let's target release-0.6 |
With ESP-IDF 5.2, some headers do not tolerate being included from an extern "C" block. To avoid any similar issue, all includes are moved outside of these blocks, thus fixing compilation of C++ code including our headers. Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w20/fix-cpp-compilation
branch
from
4fbd290
to
2d61288
Compare
ets headers also need the same change, I'll create another PR for it on main branch. |
bettio
approved these changes
May 20, 2024
bettio
added a commit
that referenced
this pull request
Jun 4, 2024
Fix C++ compilation for ets headers This PR depends on #1158. These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ESP-IDF 5.2, some headers do not tolerate being included from an extern "C" block. To avoid any similar issue, all includes are moved outside of these blocks, thus fixing compilation of C++ code including our headers.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later