feat: fixed commision rate and max rate parameter #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at/fixed-comission-rate
tbruyelle
requested changes
Sep 24, 2025
|
|
||
| if msg.CommissionRate.GT(maxCommissionRate) { | ||
| return nil, errorsmod.Wrapf(types.ErrCommissionLTMaxRate, "cannot set validator (%s) commission to more than minimum rate of %s", msg.CommissionRate.String(), maxCommissionRate.String()) | ||
| } |
There was a problem hiding this comment.
Duplicated code.
Could also be simplified with a single condition, something like this:
if msg.CommissionRate.LT(minCommissionRate) || msg.CommissionRate.GT(maxCommissionRate) {
return nil, errorsmod.Wrapf(types.ErrCommissionOutOfBound,
"commission rate (%s) must be between %s and %s",
msg.CommissionRate.String(), minCommissionRate.String(), maxCommissionRate.String(),
)
}|
|
||
| simState.AppParams.GetOrGenerate(historicalEntries, &histEntries, simState.Rand, func(r *rand.Rand) { histEntries = getHistEntries(r) }) | ||
|
|
||
| simState.AppParams.GetOrGenerate(maximumCommissionRate, &histEntries, simState.Rand, func(r *rand.Rand) { maxCommissionRate = getMaxCommissionRate(r) }) |
There was a problem hiding this comment.
For some curious reason, minCommissionRate is not initialized here. Secondly I don't think you should pass the address og histEntries here.
| DefaultHistoricalEntries uint32 = 10000 | ||
|
|
||
| // DefaultMaxCommission default maximum commission. | ||
| DefaultMaxCommission = 100 // 30% (30/100 = 0.3 = 30% |
There was a problem hiding this comment.
// 30% (30/100 = 0.3 = 30%
This comment seems wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close atomone-hub/atomone#172