Skip to content

Conversation

tbruyelle
Copy link
Collaborator

BurnDepositNoThreshold has a default value of 0.8.

Copy link
Collaborator

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change I would suggest doing, but aside from that it looks good

Copy link
Collaborator

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hold off from merging for now, but LGTM

@giunatale
Copy link
Collaborator

actually, looking at this again I think we made the same mistake in getQuorumAndThreshold and we can remove the error in Tally altogether because getQuorumAndThreshold should not return an error and use the Must APIs

@tbruyelle
Copy link
Collaborator Author

actually, looking at this again I think we made the same mistake in getQuorumAndThreshold and we can remove the error in Tally altogether because getQuorumAndThreshold should not return an error and use the Must APIs

Good catch, I converted all to MustNew* and so removed the returned error from getQuorumAndThreshold and from Tally function. 658af5d

Copy link
Collaborator

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@giunatale giunatale merged commit 8dcdde3 into giunatale/gov/dynamic-deposit Mar 18, 2025
14 checks passed
@giunatale giunatale deleted the tbruyelle/feat/no-threshold-burn-deposit branch March 18, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants