-
Notifications
You must be signed in to change notification settings - Fork 28
feat(x/gov): burn deposit if no votes > BurnDepositNoThreshold
#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/gov): burn deposit if no votes > BurnDepositNoThreshold
#90
Conversation
wwith 0.7 as default value
update default value to 0.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change I would suggest doing, but aside from that it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's hold off from merging for now, but LGTM
actually, looking at this again I think we made the same mistake in |
Good catch, I converted all to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
Co-authored-by: Giuseppe Natale <[email protected]>
…hreshold-burn-deposit
BurnDepositNoThreshold
has a default value of0.8
.