test(x/gov): independent cases in KeeperTestSuite #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State was not reinitialized between test cases, which was confusing for some scenario and forced sometimes to reset things like the deposit throttling. The fix consists only of calling `suite.reset()` in `KeeperTestSuite.SetupSubTest()`, the other changes removes any correlation previously made by the test cases about this common state.
|
I wanted to do a "lighter" solution tbh with my approach, but this is more rigorous solution. TY |
giunatale
approved these changes
Mar 28, 2025
giunatale
changed the title
giunatale
merged commit 18b385d
into
giunatale/dynamic-deposit/time-independent-increase
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State was not reinitialized between test cases, which was confusing for some scenario and forced sometimes to reset things like the deposit throttling.
The fix consists only of calling
suite.reset()inKeeperTestSuite.SetupSubTest(), the other changes removes any correlation previously made by the test cases about this common state.