Skip to content
This repository has been archived by the owner on Sep 25, 2021. It is now read-only.

Implement several feature requests #59

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lbaca
Copy link

@lbaca lbaca commented Jan 16, 2020

This pull request implements three feature requests:

While I have tested these changes on my own setup, I am quite new to the whole process (LitElement, rollup, custom Lovelace cards, GitHub, working on forks, etc.). Therefore, please be aware that I may have taken some steps that may not be as you would usually expect them. Don't hesitate to correct me, as I wish to learn!

@vmcosco
Copy link

vmcosco commented Jan 20, 2020

Thanks! How do these options implemented in the card config?

@lbaca
Copy link
Author

lbaca commented Jan 20, 2020

Thanks! How do these options implemented in the card config?

I've updated the README.md to describe the two new options.

(BTW, do you know a better way to display a fragment of a file diff in a reply such as this one?)

@vmcosco
Copy link

vmcosco commented Jan 21, 2020

(BTW, do you know a better way to display a fragment of a file diff in a reply such as this one?)

I do not. Sorry. Do you know when v0.90 will be pushed out to HACS?

@lbaca
Copy link
Author

lbaca commented Jan 21, 2020

Do you know when v0.90 will be pushed out to HACS?

This is my first involvement with this project other than as a user, so I really don't know. It's up to @atomic7777.

Enabled when maxDaysToShow is set to zero.

Resolves atomic7777#52
@lbaca lbaca changed the title Implement two feature requests Implement three feature requests Jan 22, 2020
Implemented with the maxEventCount option; defaults to zero (unlimited).

Resolves atomic7777#37
@lbaca lbaca changed the title Implement three feature requests Implement several feature requests Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants