Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fixing #10 - trailing white space should not be deleted by default. #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccoenen
Copy link
Contributor

@ccoenen ccoenen commented Feb 20, 2015

No description provided.

@winstliu
Copy link
Contributor

You appear to have broken all specs related to the removeTrailingWhitespace option.

Also as an aside-I still think that this option should be on by default for the reasons listed in #10.

@ccoenen
Copy link
Contributor Author

ccoenen commented Feb 20, 2015

Thanks for the notice. I'm working on that as we speak. Sadly, i didn't yet figure out how to run the test suite on my local machine. This is my first pull request to atom (one of its packages, that is). I'll probably keep the Travis CI busy for a little longer.

@ccoenen
Copy link
Contributor Author

ccoenen commented Feb 20, 2015

ah that's better.
For some of the tests, it was really tricky to decide whether to just default to the "old" default setting, or not. I think - whether or not the actual setting gets merged or not - the specs are better now than before.

@notslang
Copy link

👎, for the reasons listed in #10

@ccoenen
Copy link
Contributor Author

ccoenen commented Feb 25, 2015

Well, 👍 for the reasons listed in #10. So we're even, right?

@notslang
Copy link

@ccoenen - haha, yup - you've neutralized my 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants