🐛👞 prevents orphaned editor in buffer destroy listener

[jasisk]

Previously, the whitespace package would bind listeners on buffer events per editor, and unbind when the buffer was destroyed.

The problem is apparent when you use split a pane because, currently, the new copied editor is assigned the same buffer. As a result, if you close one of the editors, the listener is still bound with a reference to an editor that is no longer in your active workspace (because the buffer hasn't been destroyed yet).

This ultimately throws when you call getSelectedBufferRanges on the orphaned editor in ensureSingleTrailingNewline (introduced in dbb992b).

My test is probably pretty bad (getActivePane? ) but I bounced around dev tools until I learned just enough API to write it so no hard feelings if you :trashcan: it.

Also, make :trashcan: a thing pretty please.

Here's a gif demonstrating the issue:

Steps to reproduce:

1. Enable ensureSingleTrailingNewline
2. Save a file with a trailing new line
3. Split that file
4. Close the original editor
5. Remove trailing newline from the other editor
6. Attempt to save

[kevinsawicki]

Thanks for this, but I just pushed a fix for it here: 80458b1

[jasisk]

@kevinsawicki is a sly dog. Committed as I typed up my PR.

[jasisk]

... and we comment 1 second apart. ✨

[kevinsawicki]