Skip to content
This repository has been archived by the owner on Apr 6, 2018. It is now read-only.

Make removes safe for normal-mode-input-element (fixes #713) #1092

Closed
wants to merge 2 commits into from
Closed

Make removes safe for normal-mode-input-element (fixes #713) #1092

wants to merge 2 commits into from

Conversation

mikeylemmon
Copy link

Fixes #713

@mikeylemmon mikeylemmon mentioned this pull request May 24, 2017
Closed
@mikeylemmon
Create safeRemove method for normal-mode-input-element
7ef67a3 
normal-mode-input-element's @confirm, blur listener, and viewModel's
onDidFailToCompose handler can result in redundant calls to remove the
normal-mode-input-element. This commit makes removal idempotent.

Fixes #713
@mikeylemmon mikeylemmon changed the title Catch and ignore exceptions caused by @view.remove Make removes safe for normal-mode-input-element (fixes #713) May 28, 2017
@lee-dohm
Copy link
Contributor

lee-dohm commented Apr 5, 2018

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!

@lee-dohm lee-dohm closed this Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeylemmon @lee-dohm @winstliu