Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

added inline syntax highlighting for liquid #153

Closed
wants to merge 5 commits into from

Conversation

puranjayjain
Copy link

adds shopif snippets to gfm.
trying to solve #145

adds shopif snippets to gfm
@fusion809
Copy link

fusion809 commented May 20, 2016

Ah. Snippets aren't the issue, #145 is about syntax highlighting for Liquid in Markdown not adding Liquid snippets to this package.

@puranjayjain
Copy link
Author

@fusion809 totally got confused removing that and adding the relevant files

@puranjayjain puranjayjain changed the title Mega snippet boost added syntax highlighting to liquid May 20, 2016
@fusion809
Copy link

fusion809 commented May 20, 2016

Ah, I don't think ya quite understand what #145 is all about still. I don't want this package to syntax highlight .liquid files, I want this package to syntax highlight Liquid code that is in Markdown files. For example, here is an example markdown file:

---
title:       An Overview of my Eight Favourite Text Editors and IDEs
date:        2016-05-30 +1000
categories:  text-editors, integrated-development-environments, comparisons
layout:      post3
permalink:   /free-text-editors-and-ides/
---

<!-- Introduction-->
{% include_relative 01-introduction.md %}

<!-- Atom-->
{% include_relative 02-atom.md %}

<!-- Brackets-->
{% include_relative 03-brackets.md %}

<!-- GNU Emacs-->
{% include_relative 04-emacs.md %}

<!-- Komodo Edit-->
{% include_relative 05-komodo.md %}

<!-- LightTable-->
{% include_relative 06-lighttable.md %}

<!-- Sublime Text-->
{% include_relative 07-sublime.md %}

<!-- Vim-->
{% include_relative 08-vim.md %}

<!-- VScode-->
{% include_relative 09-vscode.md %}

<!-- Table1-->
{% include_relative 10-table1.html %}

<!-- Footnotes-->
{% include_relative 11-footnotes.md %}

and I want {% include_relative ... %} to be highlighted the way the language-liquid package does.

@puranjayjain
Copy link
Author

@fusion809 ah now I get your exact problem.

@puranjayjain puranjayjain changed the title added syntax highlighting to liquid added syntax highlighting for liquid May 20, 2016
@puranjayjain puranjayjain changed the title added syntax highlighting for liquid added inline syntax highlighting for liquid May 20, 2016
@puranjayjain
Copy link
Author

puranjayjain commented May 20, 2016

@fusion809 yes I think that was what you wanted.
What I thinkg is that problem could be solved by adding including gfm and markdown language in the liquid language package that way the liquid snippets will present and all the relevant liquid and markdown sytax both will be higlighted. What are your thoughts about it @burodepeper

Edit:
I'm thinking on the lines of the language-babel package which adds es6 sytax to javascript. So when a user enables it the editor switches to that language for relevant pacakges which contain es6 sytax

@fusion809
Copy link

fusion809 commented May 20, 2016

@puranjayjain You are missing a } at the end of the grammars/gfm.cson file. After making this fix locally on my machine I found the package is not providing the inline liquid syntax-highlighting I expected. See in this screenshot (and before you say, "Did you reload Atom after making these changes to language-gfm?" I did! I have now reloaded Atom twice to check if the package is doing as intended.)
screenshot_20160520_171011

@fusion809
Copy link

fusion809 commented May 20, 2016

@puranjayjain Any ideas of how to solve this problem and make the package provide syntax-highlighting for my Liquid tags?

@burodepeper I suspect you might have some ideas of how to get this pull to work.

@burodepeper
Copy link

I'll look at this later today. Should be an easy fix.

@burodepeper
Copy link

Quick update: I noticed that some things have to be fixed in language-liquid too to address @fusion809's original issue. No big issues though.

@puranjayjain I think it's easiest if you close this PR, and then I'll create a new one.

@puranjayjain
Copy link
Author

ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants