This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
attempt to improve search pertinence #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed it, please review. |
|
How is this different from PR #15? |
Add a test for substring
| 'Git Plus: Push', | ||
| 'Git Plus: Show' | ||
| ] | ||
| expect(bestMatch(candidates, 'push')).toBe 'Git Plus: Push' |
|
Could you add another test case for getting the correct ordering when searching for "install"? |
|
Please merge #22 instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a arbitrary substring match bonus to the scorer to improve pertinence.
We need a better scoring for query substring matches.
e.g. in command-palette
There is still the issue of highlighting the correct substring though