Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Update devDependencies #51

Merged
merged 9 commits into from
Jan 19, 2021
Merged

Update devDependencies #51

merged 9 commits into from
Jan 19, 2021

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Oct 24, 2020

Description of the change

  • This PR updates the devDependencies of event-kit.
  • It uses babel-preset-atomic as the babel preset.
  • Allows the non-transformed code to be included in the npm package (lib folder).

It uses my joanna fork which supports parsing new JavaScript. If you merge that PR, we can use the package itself. atom/joanna#12.

Benefits

  • By using non-transformed code, users can use ES6 classes. This is useful since babel transformation converts the ES6 classes to prototypical functions. By including the lib folder, the users can opt into using the ES6 class code by requiring the event-kit/lib/event-kit

  • Allows us to modernize event-kit code in the future PRs (see Optimizations (Parcel + CompositeDisposable + Disposable + Emitter) #52)

Verification

All the tests pass:
image

@aminya
Copy link
Contributor Author

aminya commented Oct 24, 2020

@darangi @sadick254 Consider this and #52 if you had time :). Pretty straight forward updates.

@sadick254 sadick254 merged commit 65da67e into atom:master Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants