This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Upgrade npm to 6.2.0 to fix Windows long file path issues #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change updates
apm
to usenpm
6.2.0 to benefit from some major dependency restructuring and flattening that shaved about 60 characters off ofnpm
's directory tree paths, specifically to aid with installing Node.js on Windows.Since we've been fighting with "path too long" errors with Squirrel for a long time, this new version of
npm
is a welcome relief and a path forward to finally deliver side-by-side Atom release channel installations on Windows.Alternate Designs
I also tried running
npm dedupe
in Atom'sapm
folder in various different ways and it either brokeapm
, broke Atom's app packaging, or had no real effect. Updating tonpm
6.2.0 is the only thing that brought results.I also tried updating to
npm
6.3.0 but ran into some issues withapm
after doing that, so it's probably better to hold off for now.Benefits
Possible Drawbacks
Minor bugs introduced by 6.2? So far everything seems solid.
Applicable Issues