Implemented vision_msgs #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nalwa-Jayesh
commented
Sep 19, 2023
•
Nalwa-Jayesh
commented
- Vision msgs being sent
- Detecting the objects
- Vision msgs can be seen in terminal while the node is running
NOEMOJI041
requested changes
Sep 19, 2023
|
|
||
| detection_arr.detections.append(detection_msg) | ||
|
|
||
|
|
There was a problem hiding this comment.
Add comments to everyline to make code understandable to others.
jasmeet0915
reviewed
Oct 9, 2023
| @@ -3,7 +3,7 @@ object_detection: | |||
| input_img_topic: color_camera/image_raw | |||
| output_bb_topic: object_detection/img_bb | |||
| output_img_topic: object_detection/img | |||
| publish_output_img: 1 | |||
| output_vision_topic: object_detection/vision_msg | |||
There was a problem hiding this comment.
I think we should rename the topic to object_detection/detection_info as it might be more self explanatory.
|
PR is outdated, too many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.