Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add media-query to resize font-size on high dpi screens #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

idleberg
Copy link
Contributor

Requirements for Contributing a Bug Fix

Identify the Bug

#353

Description of the Change

This PR adds a media-query addressing high DPI screens:

  • min-device-pixel-ratio: 2: This condition checks if the device's pixel ratio is at least 2. This is typically used for high-resolution displays like Retina screens.

  • min-resolution: 192dpi: This condition checks if the device's resolution is at least 192 dots per inch (dpi).

  • min-resolution: 2dppx: This condition checks if the device's resolution is at least 2 dots per pixel (dppx). This is another way to specify high-resolution displays.

Alternate Designs

Possible Drawbacks

Verification Process

Release Notes

Adds media-query for high DPI screen that enlarges all icons by 200%

Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested? I don't have Atom installed anymore

@idleberg
Copy link
Contributor Author

I tested it on a Dell XPS with HiDPI and an Apple Studio Display, but somebody else should probably verify this. Also, make sure that the icons look fine on "normal" displays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants