Fix "Upload Artifacts" job in CI (makes CI pass) #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream switched from S3 to Azure Storage for uploading binary blobs during CI. (Used for serving releases from the official website?) Just like we used to have it set up to skip uploading to Amazon S3 (due to this fork's lack of credentials), this commit adjusts to the changes from upstream to also skip uploading to Azure. (This fork doesn't have credentials for an Azure Storage account, so skipping the upload is needed in order for CI to pass.) (This first commit only adjusts the JS script that does the uploading. Another change is needed to pass the env vars properly to the script.)
Update the release-branch-build and nightly-release pipeleine YAML to: - Add the _VAR_NAME_HERE intermediate var for Azure - Delete unused Amazon S3-related vars - Restore use of the intermediate vars (These make sure that vars are properly seen as empty/undefined in scripts, if unset in CI. They were accidentally reverted during a merge of upstream commits, I think?) This makes sure the upload-artifacts.js script is able to properly detect whether the env vars are unset, so it can skip attempting to upload stuff to services we can't auth to (due to no credentials). Skipping these uploads avoids errors, and thus allows CI to pass.
URL shorteners are kind of iffy IMO. Makes link hijacking more likely. Better to use a direct link, IMO.
aminya
approved these changes
Sep 19, 2022
|
It worked on my personal CI instance: Passing CI on Release Branch Build pipeline on my CI: link to passing CI run See this line specifically, from the output of my CI run's "Upload Artifacts" job:
There is a tiny typo -- I included an unnecessary comma in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix (from template, click to expand):
Identify the Bug
CI isn't passing, because it tries to upload binary blobs to Azure Storage, but without the needed credentials. This errors out, causing CI to fail (even after the build and tests may have succeeded.)
Description of the Change
script/vsts/upload-artifacts.jsto skip uploading binary blobs to Azure Storage if env varATOM_RELEASES_AZURE_CONN_STRINGis unset or empty (more precisely: if it is falsy in JS).Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
CI should pass if this PR is done right.
NOTE: The PR pipeline will not test this change. I will manually run the release branch pipeline on my personal CI instance to see if it passes. CI passing directly on this PR will be the "Pull Requests" pipeline, which has nothing to do with this change.
Update: It works for me on my personal CI instance: CI link
Release Notes
N/A