Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java Execution + Support UF8 strings #2470

Merged
merged 7 commits into from
May 12, 2021

Conversation

mhatano
Copy link
Contributor

@mhatano mhatano commented May 12, 2021

Quick fix for the issue #1166, Java build in non-English editions of Windows will result garbled message, stdout and stderr displayed.
Please note that this fix would have further issue: if user's final target deployment would have different encodings from all-UTF-8 setup, (such as "normal" Windows cmd.exe, they normally have ANSI encodings for average users) so testing and evaluating might become more difficult.)

Steps to reproduce:
  Atom: 1.57.0 (Windows x64)
Script: 3.31.3
Grammar: java.js
Java: AdoptOpenJDK 11.0.9.1 (HotSpot)

Quick fix for the issue atom-community#1166, Java build in non-English editions of Window will result garbled message, stdout and stderr displayed.
This fix would have further issue: if user's final target deployment would have different encodings from all-UTF-8 setup, (such as "normal" Windows cmd.exe, they normally have ANSI encodings for average users) so testing and evaluating might become more difficult.
@aminya aminya added the bug label May 12, 2021
Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this and I get this error:

javac: invalid flag: ?J-Dfile.encoding=UTF-8
Usage: javac <options> <source files>
use -help for a list of possible options
[Finished in 0.694s]

@aminya aminya changed the title Fix Garbled message in non-English Windows Fix Java Execution + Support UF8 strings May 12, 2021
Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is fixed! 🎉

@mhatano
Copy link
Contributor Author

mhatano commented May 12, 2021

Sorry for my typo. Thanks,

I tried this and I get this error:

javac: invalid flag: ?J-Dfile.encoding=UTF-8
Usage: javac <options> <source files>
use -help for a list of possible options
[Finished in 0.694s]

@aminya aminya merged commit 15dfcc3 into atom-community:master May 12, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lucas-berth
Copy link

Hello: I am using Atom as well with Java and brand new install of JDK

Still getting this error even though it runs on VScode:
error: invalid flag: Projects\My Usage: javac <options> <source files> use --help for a list of possible options

I am not understanding how to fix this @aminya. It looks like you have the fix, but I am unsure how to fix this. Any help is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Atom script package requires script execution screen encoding in Java
3 participants