-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Java Execution + Support UF8 strings #2470
Conversation
Quick fix for the issue atom-community#1166, Java build in non-English editions of Window will result garbled message, stdout and stderr displayed. This fix would have further issue: if user's final target deployment would have different encodings from all-UTF-8 setup, (such as "normal" Windows cmd.exe, they normally have ANSI encodings for average users) so testing and evaluating might become more difficult.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this and I get this error:
javac: invalid flag: ?J-Dfile.encoding=UTF-8
Usage: javac <options> <source files>
use -help for a list of possible options
[Finished in 0.694s]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it is fixed! 🎉
Sorry for my typo. Thanks,
|
🎉 This PR is included in version 3.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hello: I am using Atom as well with Java and brand new install of JDK Still getting this error even though it runs on VScode: I am not understanding how to fix this @aminya. It looks like you have the fix, but I am unsure how to fix this. Any help is appreciated. |
Quick fix for the issue #1166, Java build in non-English editions of Windows will result garbled message, stdout and stderr displayed.
Please note that this fix would have further issue: if user's final target deployment would have different encodings from all-UTF-8 setup, (such as "normal" Windows cmd.exe, they normally have ANSI encodings for average users) so testing and evaluating might become more difficult.)
Steps to reproduce:
Atom: 1.57.0 (Windows x64)
Script: 3.31.3
Grammar: java.js
Java: AdoptOpenJDK 11.0.9.1 (HotSpot)