-
Notifications
You must be signed in to change notification settings - Fork 87
Enable chat adapter with env variable #115
base: master
Are you sure you want to change the base?
Conversation
So this will only enable provided adapters for slack and hipchat, and there is no way to add custom adapters via this env var. I think this should be stated clearly. Maybe using |
It would actually work with whatever xyz adapter, provided you implement a |
But in |
Correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "hubot-deploy", | |||
"version": "0.13.24", | |||
"version": "0.13.24-fork", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do 0.14.0.pre1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This reverts commit b3fe90e.
npm doesn't like the pre1 suffix
any update on this ? |
slack.coffee
andhipchat.coffee
are unused and burried in thedocs
folder. They could be useful just as they are.With this new
HUBOT_DEPLOY_ADAPTER
env var, it is easier to leverage them