Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Enable chat adapter with env variable #115

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

helaili
Copy link

@helaili helaili commented Sep 12, 2016

slack.coffee and hipchat.coffee are unused and burried in the docs folder. They could be useful just as they are.

With this new HUBOT_DEPLOY_ADAPTER env var, it is easier to leverage them

@willdurand
Copy link
Contributor

So this will only enable provided adapters for slack and hipchat, and there is no way to add custom adapters via this env var. I think this should be stated clearly.

Maybe using HUBOT_DEPLOY_BUILTIN_ADAPTER?

@helaili
Copy link
Author

helaili commented Sep 12, 2016

It would actually work with whatever xyz adapter, provided you implement a xyz.coffee file in /src/adapters

@willdurand
Copy link
Contributor

But in src/adapters of this package only, right?

@helaili
Copy link
Author

helaili commented Sep 12, 2016

Correct

Copy link
Owner

@atmos atmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helaili Let's bump the minor version.

@ys We're doing heroku pipelines a bit differently in our custom setup. Do you have any input on this?

@@ -1,6 +1,6 @@
{
"name": "hubot-deploy",
"version": "0.13.24",
"version": "0.13.24-fork",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do 0.14.0.pre1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meltwater-haven
Copy link

any update on this ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants