test_runner: fix spec skip detection

PR-URL: nodejs#47537 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
atlowChemi · Apr 16, 2023 · 46a3cff · 46a3cff
1 parent a777bbd
commit 46a3cff
Show file tree

Hide file tree

Showing 5 changed files with 579 additions and 11 deletions.
diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -190,9 +190,9 @@ class FileTest extends Test {
         let directive;
 
         if (skip) {
-          directive = this.reporter.getSkip(node.reason);
+          directive = this.reporter.getSkip(node.reason || true);
         } else if (todo) {
-          directive = this.reporter.getTodo(node.reason);
+          directive = this.reporter.getTodo(node.reason || true);
         } else {
           directive = kEmptyObject;
         }

diff --git a/test/fixtures/test-runner/output/spec_reporter.snapshot b/test/fixtures/test-runner/output/spec_reporter.snapshot
@@ -150,7 +150,7 @@
  test with a name and options provided (*ms) # SKIP
  functionAndOptions (*ms) # SKIP
  escaped description \ # \#\ 
- 	     (*ms)
+ 	     (*ms)
  escaped skip message (*ms) # SKIP
  escaped todo message (*ms)
  escaped diagnostic (*ms)

diff --git a/test/fixtures/test-runner/output/spec_reporter_cli.js b/test/fixtures/test-runner/output/spec_reporter_cli.js
@@ -0,0 +1,12 @@
+// Flags: --no-warnings
+'use strict';
+require('../../../common');
+const fixtures = require('../../../common/fixtures');
+const spawn = require('node:child_process').spawn;
+
+const child = spawn(process.execPath,
+                    ['--no-warnings', '--test', '--test-reporter', 'spec', fixtures.path('test-runner/output/output.js')],
+                    { stdio: 'pipe' });
+// eslint-disable-next-line no-control-regex
+child.stdout.on('data', (d) => process.stdout.write(d.toString().replace(/[^\x00-\x7F]/g, '').replace(/\u001b\[\d+m/g, '')));
+child.stderr.pipe(process.stderr);