JPERF-1454 explain drilldowns #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expect unexplained time to be smaller than current 900 ms. TDD: red
But it's not enough to reduce unexplained time. TDD: red
Reduce unexplained time, but it's not enough. TDD: red
Reduce unexplained time even more. TDD: red
Allow 1 ms for rounding errors. TDD: red
TDD: red
Negative unexplained time means we added too much time segments. This might mean we're double-counting a period of time or we count things from outside the measurement. TDD: red
Extract test cases as separate `@Test`. No need to plot waterfalls in generic `shouldExplainAlmostEverything`, because the specific test cases should plot their own. TDD: red
Switch TimeTrain from Durations to Instants. Without that, the ActionMetric.start and timeOrigin represented two independent time axes. Comparing and subtracting durations from different time dimensions was mind-bending. Now it's all the same time axis: `Instant`. Surprisingly, the old `shouldCalculateRainbowWithNavigation` case had overblown `excessJavascript`, while in reality it's a huge `preNav`. Thanks to timeOrigin we now can know if the missing time is after or before the waterfall. In this case it's `LogInAction`, which actually does two navigations within the same `ActionMetric`, so the second one overwrites the first, effectively hiding it from the waterfall. TDD: green
mgrzaslewicz
force-pushed
the
issue/JPERF-1454-aggregate-waterfalls
branch
4 times, most recently
from
3a1e471
to
8e5d9f6
Compare
TDD: refactor
dagguh
force-pushed
the
issue/JPERF-1454-aggregate-waterfalls
branch
from
8e5d9f6
to
4f8b734
Compare
mgrzaslewicz
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.