Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARC-1977 - Rotating secrets in Lastpass: STORAGE_SECRET #2123

Merged
merged 1 commit into from
May 16, 2023
Merged

ARC-1977 - Rotating secrets in Lastpass: STORAGE_SECRET #2123

merged 1 commit into from
May 16, 2023

Conversation

krazziekay
Copy link
Collaborator

@krazziekay krazziekay commented May 16, 2023 •
edited
Loading

What's in this PR?

  • Added a new environment variable in Vault and used this new variable for creating cookies.

Why

  • It was using the STORAGE_SECRET, which was exposed due to a vulnerability. So, using a new variable for creating cookies.

How was this tested?

  • In staging & local environments

@krazziekay krazziekay self-assigned this May 16, 2023
@krazziekay krazziekay requested a review from a team as a code owner May 16, 2023 02:56
@krazziekay krazziekay merged commit 5d97c5d into main May 16, 2023
@krazziekay krazziekay deleted the ARC-1977-storage-secret branch May 16, 2023 03:27
@MaxMood96 MaxMood96 mentioned this pull request Jul 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gxueatlassian gxueatlassian gxueatlassian approved these changes

Assignees

@krazziekay krazziekay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krazziekay @gxueatlassian