Performance improvement: avoid creating multiple same read-only objec…

…ts (open-telemetry#2104) Signed-off-by: Bogdan Drutu <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
atlassian-forks · Jul 20, 2021 · 9b1a5f7 · 9b1a5f7
1 parent ab78dbd
commit 9b1a5f7
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/sdk/trace/span.go b/sdk/trace/span.go
@@ -262,11 +262,13 @@ func (s *span) End(options ...trace.SpanEndOption) {
 	}
 	s.mu.Unlock()
 
-	sps, ok := s.tracer.provider.spanProcessors.Load().(spanProcessorStates)
-	mustExportOrProcess := ok && len(sps) > 0
-	if mustExportOrProcess {
+	if sps, ok := s.tracer.provider.spanProcessors.Load().(spanProcessorStates); ok {
+		if len(sps) == 0 {
+			return
+		}
+		snap := s.snapshot()
 		for _, sp := range sps {
-			sp.sp.OnEnd(s.snapshot())
+			sp.sp.OnEnd(snap)
 		}
 	}
 }