Fix semver range operations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReDrUm
reviewed
Feb 17, 2022
| @@ -263,32 +263,32 @@ it("should not error if the range is included in the allowedDependencyVersions o | |||
| it("should error and fix the version to the closest allowed one when adding an allowed major", () => { | |||
| const options = { | |||
| allowedDependencyVersions: { | |||
| something: ["1.0.0", "2.0.0"] | |||
| something: ["^1.0.0", "^2.0.0"] | |||
There was a problem hiding this comment.
Prob worth retaining a mixture of with and without carets in the tests
There was a problem hiding this comment.
Yep, will do a mixture here as well
ReDrUm
reviewed
Feb 17, 2022
| }); | ||
|
|
||
| it("should error and fix the version to the highest allowed one when adding a newer major", () => { | ||
| const options = { | ||
| allowedDependencyVersions: { | ||
| something: ["1.0.0", "2.0.0"] | ||
| something: ["1.0.0", "^2.0.0"] |
ReDrUm
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most semver APIs don't work on ranges. It slipped through our unit tests because the versions in all test cases don't have a caret.