Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor finalize-history #3535

Open
aadcg opened this issue Nov 22, 2024 · 2 comments
Open

Refactor finalize-history #3535

aadcg opened this issue Nov 22, 2024 · 2 comments
Assignees
@aadcg
Labels
4-series Related to releases whose major version is 4. history Related to history handling.

Comments

@aadcg
Copy link
Member

aadcg commented Nov 22, 2024

This routine calls buffer-delete, which is backwards to say the least.
@aadcg aadcg added the 4-series Related to releases whose major version is 4. label Nov 22, 2024
@aadcg aadcg self-assigned this Nov 22, 2024
@aadcg aadcg removed their assignment Feb 4, 2025
@jmercouris
Copy link
Member

Will be fixed by #3598.

@aadcg aadcg added the history Related to history handling. label Feb 19, 2025
@aadcg aadcg mentioned this issue Feb 19, 2025
Draft
@aadcg
Copy link
Member Author

aadcg commented Feb 20, 2025

Will be fixed by #3598.

It is not fixed in its current state.

@aadcg aadcg self-assigned this Feb 20, 2025
aadcg added a commit that referenced this issue Feb 21, 2025
@aadcg
browser: Don't create a dummy buffer on startup.
3cbf5cf 
Fixes #3535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aadcg aadcg

Labels
4-series Related to releases whose major version is 4. history Related to history handling.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmercouris @aadcg