-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main << Staging #49
Merged
Main << Staging #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Grote <[email protected]>
Fix/show all impact in one comment
Revised README wording
fix: renderDownstreamAssetsComment -> createComment
# Conflicts: # dist/index.js # src/main/print-downstream-assets.js # src/utils/create-comment.js
fix: delete comment if all changes are removed
…ions comment for updating (#40)
* fix: only create issue comment when total files changed is more than 0 * fix: model name not getting detected for models in the root folder
# Conflicts: # dist/index.js # src/utils/file-system.js
* fix: only create issue comment when total files changed is more than 0 * fix: model name not getting detected for models in the root folder * fix: remove repeating models from changed files
# Conflicts: # dist/index.js # src/utils/file-system.js
* fix: only create issue comment when total files changed is more than 0 * fix: model name not getting detected for models in the root folder * fix: remove repeating models from changed files * fix: use json-stringify-safe for stringifying objects
…side models folder
* fix: only create issue comment when total files changed is more than 0 * fix: model name not getting detected for models in the root folder * fix: remove repeating models from changed files * fix: use json-stringify-safe for stringifying objects * fix: minor copy changes and extract file names for models anywhere inside models folder
# Conflicts: # src/main/print-downstream-assets.js
Bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.