Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set hard limit on total downstream assets #103

Merged
merged 9 commits into from
May 22, 2023
+6 −2
Merged

fix: set hard limit on total downstream assets #103

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97240a2
Merge pull request #49 from atlanhq/staging
Jaagrav Feb 2, 2023
2b92573
Merge pull request #50 from atlanhq/staging
Jaagrav Feb 2, 2023
ecb9a6a
Merge pull request #55 from atlanhq/staging
Jaagrav Feb 3, 2023
ed07225
Merge pull request #64 from atlanhq/staging
Jaagrav Feb 28, 2023
045f245
Merge pull request #66 from atlanhq/staging
Jaagrav Mar 1, 2023
47e2051
Merge pull request #72 from atlanhq/staging
Jaagrav Mar 8, 2023
c6e467b
Merge pull request #92 from atlanhq/staging
Jaagrav Apr 26, 2023
8540289
Merge pull request #97 from atlanhq/staging
Jaagrav May 15, 2023
653b225
fix: set a hard limit on downstream assets list
Jaagrav May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/utils/create-comment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {getInstanceUrl, isDev} from "./get-environment-variables.js";
const IS_DEV = isDev();
const ATLAN_INSTANCE_URL =
getInstanceUrl();
const ASSETS_LIMIT = 100;

export default async function renderDownstreamAssetsComment(
octokit,
Expand All @@ -13,7 +14,7 @@ export default async function renderDownstreamAssetsComment(
downstreamAssets,
classifications
) {
let impactedData = downstreamAssets.map(
let impactedData = downstreamAssets.slice(0, ASSETS_LIMIT).map(
({displayText, guid, typeName, attributes, meanings, classificationNames}) => {
let readableTypeName = typeName
.toLowerCase()
Expand Down Expand Up @@ -74,6 +75,9 @@ Materialised asset: ${getConnectorImage(materialisedAsset.attributes.connectorNa
Name | Type | Description | Owners | Terms | Classifications | Source URL
--- | --- | --- | --- | --- | --- | ---
${rows.map((row) => row.map(i => i.replace(/\|/g, "•").replace(/\n/g, "")).join(" | ")).join("\n")}

${downstreamAssets.length > ASSETS_LIMIT ? `[+${downstreamAssets.length - ASSETS_LIMIT} assets more](${ATLAN_INSTANCE_URL}/assets/${materialisedAsset.guid}/lineage?utm_source=dbt_github_action)` : ""}

</details>`

const viewAssetButton = `${getImageURL("atlan-logo", 15, 15)} [View asset in Atlan](${ATLAN_INSTANCE_URL}/assets/${asset.guid}/overview?utm_source=dbt_github_action)`
Expand Down Expand Up @@ -119,7 +123,7 @@ ${content}`
body: content,
};

console.log(content)
console.log(content, content.length)

if (IS_DEV) return content;

Expand Down