Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESH-370 | Asset Creation Bug #4203

Merged
merged 6 commits into from
Feb 24, 2025
Merged

MESH-370 | Asset Creation Bug #4203

merged 6 commits into from
Feb 24, 2025
+18 −12

Conversation

ankitpatnaik-atlan
Copy link
Collaborator

@ankitpatnaik-atlan ankitpatnaik-atlan commented Feb 18, 2025 •
edited by jira bot
Loading

Change description

While creating assets, if we attach a domainGUID to an asset , then we receive a 403 Unauthorised error. In this PR I have fixed this to enable users to attach a domainGUID while creating an asset.

JIRA: MESH-370

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

PRATHAM2002-DS
PRATHAM2002-DS previously approved these changes Feb 23, 2025
View reviewed changes
nikhilbonte21
nikhilbonte21 reviewed Feb 24, 2025
View reviewed changes
Copy link

@nikhilbonte21 nikhilbonte21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is needed for this fix?

@ankitpatnaik-atlan ankitpatnaik-atlan merged commit c7ebc09 into master Feb 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

@PRATHAM2002-DS PRATHAM2002-DS PRATHAM2002-DS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankitpatnaik-atlan @PRATHAM2002-DS @nikhilbonte21