DVX-739: Added a new attribute modelEntityAssociationQualifiedName to the ModelAttributeAssociation
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the `ModelAttributeAssociation`
cmgrote
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Since this is a denormalized qualifiedName, I think we need to force it to a keyword index like we have elsewhere — by adding a indexAs = "keyword"...
(Actually we should probably do that to the other qualifiedName fields in these Model..Association objects, too, as it looks like we've missed it elsewhere in them?)
Without it, they'll be indexed as text fields, so tokenized, etc — could give some unintended results when querying the way we want to query them (i.e. by exact-matching)...
…ualifiedName` attributes
cmgrote
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.