Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FT-566: Add Non-Technical Group Names Column to the Users sheet #1216

Merged
merged 7 commits into from
Jan 16, 2025
Merged

FT-566: Add Non-Technical Group Names Column to the Users sheet #1216

merged 7 commits into from
Jan 16, 2025

Conversation

pavanmanishd
Copy link
Collaborator

No description provided.

@pavanmanishd pavanmanishd marked this pull request as ready for review January 14, 2025 12:08
@pavanmanishd pavanmanishd requested a review from cmgrote as a code owner January 14, 2025 12:08
cmgrote
cmgrote requested changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@cmgrote cmgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update at least one of the integration tests that extracts users to validate that it is extracting the group names under these two different columns, and that the two different names for the group in each column are what you expect.

samples/packages/admin-export/src/main/kotlin/com/atlan/pkg/ae/exports/Users.kt Outdated Show resolved Hide resolved
samples/packages/admin-export/src/main/kotlin/com/atlan/pkg/ae/exports/Users.kt Outdated Show resolved Hide resolved
samples/packages/admin-export/src/main/kotlin/com/atlan/pkg/ae/exports/Users.kt Outdated Show resolved Hide resolved
@pavanmanishd pavanmanishd requested a review from cmgrote January 14, 2025 17:24
@cmgrote cmgrote added the packages Changes related to custom packages label Jan 15, 2025
@cmgrote cmgrote enabled auto-merge January 15, 2025 10:36
@cmgrote cmgrote merged commit 93f6601 into main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmgrote cmgrote cmgrote approved these changes

Assignees
No one assigned
Labels
packages Changes related to custom packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavanmanishd @cmgrote