Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FT-820 Add SnowflakeDynamicTable as possible parentType #1132

Merged
merged 12 commits into from
Dec 23, 2024
Merged

FT-820 Add SnowflakeDynamicTable as possible parentType #1132

merged 12 commits into from
Dec 23, 2024

Conversation

ErnestoLoma
Copy link
Collaborator

No description provided.

@ErnestoLoma ErnestoLoma requested a review from cmgrote as a code owner December 12, 2024 07:32
@ErnestoLoma ErnestoLoma changed the title Add SnowflakeDynamicTable as possible parentType. FT-820 Add SnowflakeDynamicTable as possible parentType.Add SnowflakeDynamicTable as possible parentType. Add SnowflakeDynamicTable as possible parentType. Dec 12, 2024
@ErnestoLoma ErnestoLoma changed the title FT-820 Add SnowflakeDynamicTable as possible parentType.Add SnowflakeDynamicTable as possible parentType. Add SnowflakeDynamicTable as possible parentType. FT-820 Add SnowflakeDynamicTable as possible parentType Dec 12, 2024
@ErnestoLoma ErnestoLoma requested a review from cmgrote December 12, 2024 11:30
@cmgrote cmgrote added the enhancement New feature or request label Dec 12, 2024
@cmgrote
Copy link
Collaborator

cmgrote commented Dec 12, 2024

Thinking about this a bit more, we probably need to extend the types that AssetBatch considers for its asset/view-agnosticism setting to now include SnowflakeDynamicTable, too — we should probably add that to this PR so it's all together.

@cmgrote cmgrote enabled auto-merge December 23, 2024 10:57
@cmgrote cmgrote merged commit 29abc7b into main Dec 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmgrote cmgrote cmgrote approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErnestoLoma @cmgrote