Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-5079 : Manage Policies #83

Merged
merged 6 commits into from
Jan 29, 2025
Merged

APP-5079 : Manage Policies #83

merged 6 commits into from
Jan 29, 2025

Conversation

0xquark
Copy link
Collaborator

@0xquark 0xquark commented Jan 29, 2025 •
edited
Loading

Description

This PR updates the AuthPolicy struct to improve JSON Unmarshalling and Marshalling and enhance policy search using Persona and Purpose.
• Adds handling for nested accessControl fields returned in index search responses.
• Manually tested search methods for managing policies through Purpose and Persona in main.go.

Since Managing Policies already uses IndexSearch with Persona and Purpose, there’s no need to create new integration tests for existing methods.

Related Issue

APP-5079

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes (if applicable)
  • I have updated documentation (if applicable)
  • All the checks and tests are passing locally
  • I have verified that the changes works as expected

Further Comments

@0xquark
feat: add StartsWith query filter to KeywordField
c1e76fa 
Signed-off-by: Karanjot Singh <[email protected]>
@0xquark
enhancement: add CONNECTION_QUALIFIED_NAME for search in AssetFields
58ed0b6 
Signed-off-by: Karanjot Singh <[email protected]>
@0xquark
enhancement: Update UnMarshalJSON with AuthPolicy attributes and add …
00f3aa4 
…nested UniqueAttributes struct

Signed-off-by: Karanjot Singh <[email protected]>
@0xquark
enhancement: Update UnmarshalJSON with managing Access Control-specif…
27fcac6 
…ic Attributes

Signed-off-by: Karanjot Singh <[email protected]>
@0xquark
enhancement: Handle nested AccessControl fields and basefields
723daec 
Signed-off-by: Karanjot Singh <[email protected]>
@0xquark
chore: Include main.go for examples related to managing policies
b143592 
Signed-off-by: Karanjot Singh <[email protected]>
@0xquark 0xquark marked this pull request as ready for review January 29, 2025 16:34
@0xquark 0xquark added the feature Adding this label to PR will put it in Feature section in Github Release Changelog label Jan 29, 2025
@0xquark 0xquark self-assigned this Jan 29, 2025
@0xquark 0xquark requested a review from Aryamanz29 January 29, 2025 16:34
Aryamanz29
Aryamanz29 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0xquark 0xquark merged commit a0f4bfc into main Jan 29, 2025
5 checks passed
@0xquark 0xquark mentioned this pull request Jan 30, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aryamanz29 Aryamanz29 Aryamanz29 approved these changes

Assignees

@0xquark 0xquark

Labels
feature Adding this label to PR will put it in Feature section in Github Release Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xquark @Aryamanz29