Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-5003 : Fixes maximum token TTE to 5 years #82

Merged
merged 3 commits into from
Jan 27, 2025
Merged

APP-5003 : Fixes maximum token TTE to 5 years #82

merged 3 commits into from
Jan 27, 2025

Conversation

0xquark
Copy link
Collaborator

@0xquark 0xquark commented Jan 27, 2025

Description

Set maximum token validity to 5 years in order to avoid issue with keycloack 2038 bug which leads to integer overflow by setting negative value.

Related Issue

APP-5003

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes (if applicable)
  • I have updated documentation (if applicable)
  • All the checks and tests are passing locally
  • I have verified that the changes works as expected

Further Comments

@0xquark 0xquark self-assigned this Jan 27, 2025
@0xquark 0xquark added the bug Something isn't working label Jan 27, 2025
@0xquark 0xquark requested a review from Aryamanz29 January 27, 2025 09:19
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I would also add a code comment for MaxValidity:

// The value was previously set to 13 years (409968000 secs).
// It has been reverted to 5 years due to an integer overflow issue in Keycloak.
// https://github.com/keycloak/keycloak/issues/19671
MaxValidity  = 157680000  // 5 years in seconds

@0xquark 0xquark merged commit 7450911 into main Jan 27, 2025
5 checks passed
@0xquark 0xquark deleted the APP-5003 branch January 27, 2025 09:54
@0xquark 0xquark mentioned this pull request Jan 30, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants