Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade go version to 1.19 #43

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

rittikdasgupta
Copy link
Collaborator

@rittikdasgupta rittikdasgupta commented Jul 8, 2024

NOTE: We need to pin this experimental version of "slog" since it is compatible with Go 1.19
This is required because "heracles" uses go-sdk, which currently supports Go 1.19

Slack Thread: https://atlanhq.slack.com/archives/C0503DYRV8A/p1720422366564069?thread_ts=1720422041.339659&cid=C0503DYRV8A

rittikdasgupta and others added 2 commits July 8, 2024 13:21
- Downgraded Go version to 1.19.
- Pinned `slog` to an experimental version compatible with Go 1.19.
@rittikdasgupta
Copy link
Collaborator Author

Closing PR. Atlan go has other dependency issues

# github.com/go-openapi/swag
../../pkg/mod/github.com/go-openapi/[email protected]/string_bytes.go:7:29: undefined: unsafe.StringData

@Aryamanz29 Aryamanz29 reopened this Jul 8, 2024
@Aryamanz29 Aryamanz29 merged commit 47edf23 into main Jul 8, 2024
2 checks passed
@Aryamanz29 Aryamanz29 deleted the downgrade-golang-1.19 branch July 8, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants