Return corresponding types for API methods #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't touch `Api#call`, leave it with raw responses, but convert `result` in `method_missing`.
AlexWayfer
commented
Jul 15, 2023
|
I've figured out that CI secret token is empty, that's why tests are failing: #287 (comment) |
atipugin
reviewed
Jul 18, 2023
atipugin
reviewed
Jul 18, 2023
atipugin
reviewed
Jul 18, 2023
atipugin
requested changes
Jul 18, 2023
AlexWayfer
commented
Jul 19, 2023
| result = nil | ||
| client.fetch_updates { |something| result = something } | ||
|
|
||
| expect(result).to be_a Telegram::Bot::Types::Message |
There was a problem hiding this comment.
I already have a new branch, depending on this one because of these (fixed? remade?) specs, about proper bot.stop. 😅
Now `one | another` works with `.new` without required `type`.
It's not working now, but I don't why. I've wrote to `@BotSupport`, let's wait for responses (although it was not helpful previously).
Previously there were `Update`s with `ChatMemberUpdated`, but empty `ChatMember`s inside. Now we'll pick correct classes and fill it with data.
There was an issue with old `ChatMember`, I've executed Rake task and got a lot of new types and fileds, so I've just updated them.
AlexWayfer
force-pushed
the
return_corresponding_types_for_api_methods
branch
from
459d824 to
e5ea5e7
Compare
I had them locally and that's why there were not spec fails. I wanted to add them with new API methods, but the scratched data has them.
|
I'm waiting your decision about |
atipugin
reviewed
Aug 20, 2023
AlexWayfer
force-pushed
the
return_corresponding_types_for_api_methods
branch
from
5de21db to
79685d3
Compare
|
Added VCR changes from |
There is a RuboCop offense, but for cosistency of type names let's do it so.
atipugin
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't touch
Api#call, leave it with raw responses, but convertresultinmethod_missing.Resolve #284
Resolve #286 now too.
And #278 too.