fix(x): use handlePkceVerifier for proper PKCE flow #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The X OAuth handler was generating new PKCE values on every request via inline randomUUID() calls in the config defaults. This caused the token exchange to fail because the code_verifier didn't match the original code_challenge. This fix: - Uses handlePkceVerifier utility to persist verifier in cookie - Uses S256 challenge method instead of plain (more secure) - Adds proper state validation using handleState/handleInvalidState - Removes broken inline PKCE/state generation from authorizationParams - Ensures PKCE/state values can't be overridden by user config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The X OAuth handler was generating new PKCE values on every request via inline
randomUUID()calls in the config defaults. This caused the token exchange to fail because thecode_verifierdidn't match the originalcode_challenge.Changes:
handlePkceVerifierutility to persist verifier in cookiehandleState/handleInvalidStateauthorizationParamsauthorizationParamsbefore setting secure values)Test plan
nuxt-auth-pkcecookie is set on redirect and cleared on callbacknuxt-auth-statecookie is set on redirect and cleared on callbackauthorizationParams(e.g.,prompt) still work