Support Safari on Mac and iOS #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
It doesn't work anyway.
Should behave the same in this context, as both are zero length.
filipesilva
force-pushed
the
parser-lookbehind
branch
from
6ed3db3 to
e39d530
Compare
filipesilva
commented
May 25, 2022
| @@ -231,10 +231,17 @@ | |||
| (utils/parses-to sut/inline-parser->ast | |||
|
|
|||
| ;; Any ASCII punctuation character may be backslash-escaped | |||
| ;; NOTE: not working in JS environment same as in JVM | |||
There was a problem hiding this comment.
@neotyk would like your input on specialcasing this test. There's another test (a latex one) that is specialcased for cljs too.
I think this isn't a big issue because the hashtag tests already test that word chars before a hashtag will stop it from being a hashtage.
neotyk
reviewed
May 27, 2022
| @@ -1,816 +0,0 @@ | |||
| (ns athens.cljs-parser-test | |||
There was a problem hiding this comment.
Why do we want to get rid of it?
There was a problem hiding this comment.
I rolled it into the test/athens/parser/impl_test.clj -> impl_test.cljc change, but am not sure if that's the right thing to do. Seemed to be the same tests except for the clj/cljs differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #2096 (comment).
This PR removes lookbehind on regexes, and the check that prevents Safari from loading the app.