feat: block properties #2189
Merged
feat: block properties #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipesilva
commented
May 17, 2022
src/cljc/athens/common_db.cljc
Outdated
|
|
||
| ;; TODO: generalize and use athens.self-hosted.migrate to migrate existing datascript dbs | ||
| ;; For now (the prototyping stage) it is enough that only new servers can use the new schema. | ||
| (def schema (merge v1-schema v2-schema)) |
There was a problem hiding this comment.
Important: this PR cannot be merged before we have a migration set up for existing datascript dbs.
filipesilva
commented
May 17, 2022
| @@ -152,62 +174,79 @@ | |||
| (:page/sidebar))) | |||
|
|
|||
|
|
|||
| (defn get-children-uids-recursively | |||
There was a problem hiding this comment.
Note: this function was moved further down in the namespace.
filipesilva
commented
May 17, 2022
| (d/pull db '[:block/order :block/uid {:block/children ...}]) | ||
| (tree-seq :block/children :block/children) | ||
| (map :block/uid)))) | ||
| (defn sort-block-children |
There was a problem hiding this comment.
Note: this function was moved up within the namespace.
filipesilva
commented
May 17, 2022
filipesilva
commented
May 17, 2022
| @@ -31,12 +35,15 @@ | |||
| (let [db common-db/empty-db] | |||
| (is (= [#:op{:type :page/new, :atomic? true, :args {:page/title "Welcome"}} | |||
| #:op{:type :block/new, :atomic? true, :args {:block/uid "block-1", :block/position {:page/title "Welcome", :relation :last}}} | |||
| #:op{:type :page/new, :atomic? true, :args {:page/title "Welcome"}} | |||
There was a problem hiding this comment.
I changed the IR algo to not produce duplicate operations.
filipesilva
commented
May 17, 2022
| (bfs/internal-representation->atomic-ops db tree-with-page nil))) | ||
|
|
||
| (is (= [#:op{:type :block/new, :atomic? true, :args {:block/uid "eaa4c9435", :block/position {:page/title "title", :relation :first}}} | ||
| (is (= [#:op{:type :page/new, :atomic? true, :args #:page{:title "title"}} |
There was a problem hiding this comment.
IR now creates the location because of the changes in src/cljc/athens/common_events/graph/ops.cljc. I think this is correct.
New version offers feature parity with clojure 1.11. We use some of the 1.11 features in clojure so we need parity to use them in cljc files.
After updating to cljc 1.11.51 I started seeing some shadow-cljs errors while running java code.
filipesilva
commented
Jun 16, 2022
| (map :db/id) | ||
| (map (partial common-db/get-parent db)) | ||
| (mapcat (fn [{:block/keys [properties]}] | ||
| (println properties) |
There was a problem hiding this comment.
Nit: debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.