Skip to content

Fix nightly type incompatibility with ASR::Any#562

Merged
Blacksmoke16 merged 1 commit intomasterfrom
fix-serializer-type
Aug 2, 2025
Merged

Fix nightly type incompatibility with ASR::Any#562
Blacksmoke16 merged 1 commit intomasterfrom
fix-serializer-type

Conversation

@Blacksmoke16
Copy link
Member

Context

crystal-lang/crystal#15840 added type restrictions to the subkeys parameter of JSON::Any#dig. This PR follow up to make the same change to ASR::Any to make things compatible.

Changelog

  • Fix nightly type incompatibility with JSON::Any and ASR::Any

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added component:serializer kind:maintenance Keeping an existing feature functional labels Aug 1, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Flag Coverage Δ
compiled 31.30% <ø> (ø)
unit 96.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 100.00% <ø> (ø)
console 97.20% <ø> (ø)
dependency_injection 93.16% <ø> (ø)
dotenv 98.38% <ø> (ø)
event_dispatcher 95.90% <ø> (ø)
framework 98.09% <ø> (ø)
image_size 96.63% <ø> (ø)
mercure 94.94% <ø> (ø)
mime 99.37% <ø> (ø)
negotiation 97.93% <ø> (ø)
routing 98.38% <ø> (ø)
serializer 95.83% <ø> (ø)
spec 93.80% <ø> (ø)
validator 95.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit fbb2c49 into master Aug 2, 2025
21 of 26 checks passed
@Blacksmoke16 Blacksmoke16 deleted the fix-serializer-type branch August 2, 2025 01:41
PallasAthenaie pushed a commit to athena-framework/serializer that referenced this pull request Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:serializer kind:maintenance Keeping an existing feature functional

Development

Successfully merging this pull request may close these issues.

1 participant