Apply new upcoming formatting requirements#455
Merged
Blacksmoke16 merged 1 commit intomasterfrom Oct 11, 2024
Merged
Conversation
Blacksmoke16
added
component:framework
component:validator
component:serializer
component:console
component:dependency-injection
component:event-dispatcher
component:routing
component:dotenv
component:clock
component:mercure
kind:maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
crystal-lang/crystal#14718 was recently merged which enables the new formatting rules in nightlies in preparation for Crystal 1.15. This PR applies these new formatting requirements, which are backwards compatible due to crystal-lang/crystal#14726.
Changelog
Before merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title