schema: don't include empty Format attributes in samlp:NameIDPolicyEl…

…ement fixes crewjam#177
atezet · Nov 4, 2019 · 249aa03 · 249aa03
1 parent 97dc958
commit 249aa03
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/schema.go b/schema.go
@@ -245,7 +245,7 @@ type NameIDPolicy struct {
 // Element returns an etree.Element representing the object in XML form.
 func (a *NameIDPolicy) Element() *etree.Element {
 	el := etree.NewElement("samlp:NameIDPolicy")
-	if a.Format != nil {
+	if a.Format != nil && *a.Format != "" {
 		el.CreateAttr("Format", *a.Format)
 	}
 	if a.SPNameQualifier != nil {

diff --git a/schema_test.go b/schema_test.go
@@ -32,3 +32,17 @@ func TestAttributeXMLRoundTrip(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, expected, actual)
 }
+
+func TestNameIDFormat(t *testing.T) {
+	var emptyString string
+	el := NameIDPolicy{
+		Format: &emptyString,
+	}
+	doc := etree.NewDocument()
+	doc.SetRoot(el.Element())
+	x, err := doc.WriteToBytes()
+	assert.NoError(t, err)
+	assert.Equal(t,
+		"<samlp:NameIDPolicy/>",
+		string(x))
+}