Update tests: Use assertArrayNotHasKey() instead of expectError() bef…

…ore accessing the key
aternosorg · Sep 11, 2024 · d238bdd · d238bdd
1 parent d85fbaa
commit d238bdd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 16 deletions.
diff --git a/test/tests/Analysis/AnalysisTest.php b/test/tests/Analysis/AnalysisTest.php
@@ -118,8 +118,7 @@ public function testOffsetGet(): void
         $this->assertEquals($information, $analysis[0]);
 
         // Does not exist -> "undefined array key" error
-        $this->expectError();
-        $this->assertEquals(null, $analysis[1]);
+        $this->assertArrayNotHasKey(1, $analysis);
     }
 
     public function testOffsetSet(): void
@@ -153,7 +152,6 @@ public function testOffsetUnset(): void
         // Unset $information on $analysis[0] using the offsetUnset
         unset($analysis[0]);
         $this->assertArrayNotHasKey(0, $analysis);
-        $this->expectError();
-        $this->assertEquals(null, $analysis[1]);
+        $this->assertArrayNotHasKey(1, $analysis);
     }
 }
diff --git a/test/tests/Analysis/ProblemTest.php b/test/tests/Analysis/ProblemTest.php
@@ -74,8 +74,7 @@ public function testOffsetGet(): void
         $this->assertEquals($solution, $problem[0]);
 
         // Does not exist -> "undefined array key" error
-        $this->expectError();
-        $this->assertEquals(null, $problem[1]);
+        $this->assertArrayNotHasKey(1, $problem);
     }
 
     public function testOffsetSet(): void
@@ -109,7 +108,6 @@ public function testOffsetUnset(): void
         // Unset $solution on $problem[0] using the offsetUnset
         unset($problem[0]);
         $this->assertArrayNotHasKey(0, $problem);
-        $this->expectError();
-        $this->assertEquals(null, $problem[1]);
+        $this->assertArrayNotHasKey(1, $problem);
     }
 }
diff --git a/test/tests/Log/EntryTest.php b/test/tests/Log/EntryTest.php
@@ -91,8 +91,7 @@ public function testOffsetGet(): void
         $this->assertEquals($line, $entry[0]);
 
         // Does not exist -> "undefined array key" error
-        $this->expectError();
-        $this->assertEquals(null, $entry[1]);
+        $this->assertArrayNotHasKey(1, $entry);
     }
 
     public function testOffsetSet(): void
@@ -126,7 +125,6 @@ public function testOffsetUnset(): void
         // Unset $line1 on $entry[0] using the offsetUnset
         unset($entry[0]);
         $this->assertArrayNotHasKey(0, $entry);
-        $this->expectError();
-        $this->assertEquals(null, $entry[1]);
+        $this->assertArrayNotHasKey(1, $entry);
     }
 }
diff --git a/test/tests/Log/LogTest.php b/test/tests/Log/LogTest.php
@@ -74,8 +74,7 @@ public function testOffsetGet(): void
         $this->assertEquals($entry, $log[0]);
 
         // Does not exist -> "undefined array key" error
-        $this->expectError();
-        $this->assertEquals(null, $log[1]);
+        $this->assertArrayNotHasKey(1, $log);
     }
 
     public function testOffsetSet(): void
@@ -99,7 +98,6 @@ public function testOffsetUnset(): void
         // Unset $entry on $log[0] using the offsetUnset
         unset($log[0]);
         $this->assertArrayNotHasKey(0, $log);
-        $this->expectError();
-        $this->assertEquals(null, $log[1]);
+        $this->assertArrayNotHasKey(1, $log);
     }
 }