Remove ".paper-remapped/" from plugin path #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pped/" with "plugins/"
…lem and use pathinfo to extract the plugin name from the plugin path
…blem, add correctPluginPath() and extractPluginName() to BukkitPluginProblem
…luginPath() instead of str_replace
…remove $pluginName member and usages
…actPluginName instead, remove pluginPath and use PluginRemoveSolution instead of FileDeleteSolution
JulianVennen
requested changes
Oct 2, 2024
…nd PluginFileSolution + Add PluginInstallDifferentVersionSolution and PluginRemoveFileSolution in BukkitPluginFileProblem and just call parent::setMatches in subclasses
…if available (instead of parsing from path)
JulianVennen
approved these changes
Oct 15, 2024
…ce PluginRemoveFileSolution with FileDeleteSolution.
matthi4s
requested changes
Oct 15, 2024
test/data/Vanilla/Bukkit/Folia/folia-1-19-4-unsupported-plugin.json
Outdated
Show resolved
Hide resolved
test/data/Vanilla/Bukkit/Paper/paper-multiple-depepdencies-1-21-1.log
Outdated
Show resolved
Hide resolved
test/data/Vanilla/Bukkit/Paper/paper-plugin-unsupported-class-version-1-16-5.json
Outdated
Show resolved
Hide resolved
…-dependencies-1-21-1
… name from the match group for the plugin name, instead of using the plugin file name
matthi4s
approved these changes
Oct 15, 2024
JulianVennen
approved these changes
Oct 18, 2024
…nFileProblem back to PluginFileProblem
matthi4s
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest version 1.21, Paper has changed some internals so that the plugins are apparently loaded from the path
/plugins/.paper-remapped/instead of/plugins/. This also causes the error messages to change the plugin path from/plugins/<filename>to/plugins/.paper-remapped/<filename>.We extract the plugin path from the log and use it in the problem message that we display to the user.
We also use the plugin path to display it in solutions. E.g.: Delete the file
plugins/.paper-remapped/mclogs-bukkit-dev.jar.But the user cannot see or access the .paper-remapped folder, so they cannot delete the file from there.
This can lead to confusion.
Therefore, this PR changes this behavior and replaces the path
/plugins/.paper-remapped/with/plugins/in all places.In addition, this PR changes the following:
PluginProblemclass :correctPluginPathchangesplugins/.paper-remapped/toplugins/extractPluginNamecan extract the name of the plugin from the path, this can simplify some regexes in the problem classes$pluginNamecan be removed and they offer thePluginInstallDifferentVersionSolutionPluginInstallDifferentVersionSolutiontoUnsupportedClassVersionProblem