Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable i386 arch for Makefile all builds #328

Merged
merged 1 commit into from
May 1, 2024

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented May 1, 2024

Changes

  • update scheduled-monthly.yml workflow
    • explicitly enable makefile-enable-i386-architecture input
    • explicitly enable makefile-build-all input
    • explicitly enable workflow_dispatch setting to allow manually triggered execution (mostly for troubleshooting)
    • expand os-dependencies input list to include i386 arch packages to allow building Linux x86 Fyne toolkit dependent binaries as part of scheduled monthly make all invocation on Ubuntu x64 OS
  • update Makefile
    • update depsinstall recipe to note that there are additional build requirements for Linux x86 assets on Linux x64 OS
  • update README.md
    • expand dependencies coverage for the building from source section - add steps for enabling i386 architecture on Ubuntu x64 OS - add i386 arch packages
    • minor wording tweaks

References

- update `scheduled-monthly.yml` workflow
  - explicitly enable `makefile-enable-i386-architecture` input
  - explicitly enable `makefile-build-all` input
  - explicitly enable `workflow_dispatch` setting to allow
    manually triggered execution (mostly for troubleshooting)
  - expand `os-dependencies` input list to include `i386` arch
    packages to allow building Linux x86 Fyne toolkit dependent
    binaries as part of scheduled monthly `make all` invocation
    on Ubuntu x64 OS
- update `Makefile`
  - update `depsinstall` recipe to note that there are additional
    build requirements for Linux x86 assets on Linux x64 OS
- update `README.md`
  - expand dependencies coverage for the building from source
    section
    - add steps for enabling `i386` architecture on Ubuntu x64 OS
    - add `i386` arch packages
  - minor wording tweaks

refs GH-325
@atc0005 atc0005 added bug Something isn't working documentation Improvements or additions to documentation builds CI dependencies labels May 1, 2024
@atc0005 atc0005 added this to the v0.5.1 milestone May 1, 2024
@atc0005 atc0005 self-assigned this May 1, 2024
@atc0005 atc0005 merged commit 480adf1 into master May 1, 2024
31 checks passed
@atc0005 atc0005 deleted the i325-enable-i386-arch-for-makefile-all-builds branch May 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builds CI dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monthly make all task fails on linux-x86 recipe
1 participant