Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate URLs enclosed within angle brackets as URLs #246

Closed
atc0005 opened this issue Mar 27, 2024 · 2 comments · Fixed by #307 or #308
Closed

Evaluate URLs enclosed within angle brackets as URLs #246

atc0005 opened this issue Mar 27, 2024 · 2 comments · Fixed by #307 or #308
Assignees
@atc0005
Labels
enhancement New feature or request
Milestone
v0.5.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Mar 27, 2024 •
edited
Loading

Overview

When evaluating release v0.5.0-alpha.5 with some test input emails I noticed that it failed to recognize URLs wrapped in angle brackets as URLs.

Some light digging later I learned that wrapping URLs in angle brackets is a common practice with Outlook to prevent splitting of URLs across lines. All current tools should be updated to consider URLs wrapped within angle brackets as URLs and then strip them before parsing.

References
@atc0005 atc0005 added the enhancement New feature or request label Mar 27, 2024
@atc0005 atc0005 added this to the v0.5.0 milestone Mar 27, 2024
@atc0005 atc0005 self-assigned this Mar 27, 2024
atc0005 added a commit that referenced this issue Mar 27, 2024
@atc0005
Evaluate URLs within angle brackets
3bb6325 
Match URLs enclosed within angle brackets as URL patterns,
removing them before parsing and further evaluation as potential
Safe Links URLs.

refs GH-246
@atc0005 atc0005 mentioned this issue Mar 27, 2024
Merged
@atc0005
Copy link
Owner Author

atc0005 commented Apr 8, 2024

As of v0.5.0-alpha.15 this functionality is not present in either of:

  • usl
  • dsl

atc0005 added a commit that referenced this issue Apr 8, 2024
@atc0005
Add angle bracket input support to CLI apps
efb4f2e 
- cmd/usl
  - small refactor to move all URL cleaning behavior from
    `ReadURLsFromInput` to `ProcessInputURLs`
  - add debug logging toggle to `main` func (disabled by default)
  - fix logic bug with `safelinks.ValidSafeLinkURL` check
- cmd/dsl
  - small refactor to `processInput` func to reuse logic from
    `safelinks.DecodeInput` (functionality and test coverage)

refs GH-246
@atc0005 atc0005 mentioned this issue Apr 8, 2024
Merged
@atc0005
Copy link
Owner Author

atc0005 commented Apr 8, 2024

As of v0.5.0-alpha.15 this functionality is not present in either of:

  • usl
  • dsl

Added with GH-296 and GH-297.

@atc0005 atc0005 linked a pull request Apr 10, 2024 that will close this issue
Minor refactoring and cleanup #307
Merged
atc0005 added a commit that referenced this issue Apr 10, 2024
@atc0005
Evaluate URLs within angle brackets
57cc8a1 
Match URLs enclosed within angle brackets as URL patterns,
removing them before parsing and further evaluation as potential
Safe Links URLs.

Remove double-cleaning of inputURL left over from earlier
refactor work on cmd/usl to "pull back" functionality from
the safelinks package.

refs GH-246
@atc0005 atc0005 mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
1 participant
@atc0005