Fix panic if ParseRangeCheck returns nil #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommi2Day
force-pushed
the
fix/issue233
branch
from
52ada4a
to
830a7f2
Compare
atc0005
reviewed
Jan 17, 2024
|
Hi @Tommi2Day, Thanks for your work on this. Do you feel comfortable squashing the first and third commits together? If not, no problem: we can retain them and merge as-is. |
Tommi2Day
force-pushed
the
fix/issue233
branch
from
1e00e08
to
b8a299b
Compare
|
did a rebase and force upload, hopefully it is following your intention |
|
@Tommi2Day Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds checking of nil returns from ParseRangeString in EvaluateThreshold. it returns UNKNOWN state result and an error message.
second I added 2 tests to check this expected behavior
fixes #233, replace #234