Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix revive linting errors #201

Merged
merged 2 commits into from
May 19, 2023
Merged

Fix revive linting errors #201

merged 2 commits into from
May 19, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented May 19, 2023

  • Split Example_usingOnlyTheProvidedConstants function to resolve unreachable-code linting error
  • Fix if-return revive linting error

@atc0005
Split Example_usingOnlyTheProvidedConstants func
9c50641 
Split into two separate funcs to avoid `unreachable-code`
linting error:

- Example_usingOnlyTheProvidedExitCodeConstants
- Example_usingOnlyTheProvidedConstants
@atc0005
Fix if-return revive linting error
5924994 
Update `(nagios.PerformanceData).Validate` method to return
the result directly from the last validation helper function.
@atc0005 atc0005 added bug Something isn't working linting labels May 19, 2023
@atc0005 atc0005 added this to the Next Release milestone May 19, 2023
@atc0005 atc0005 self-assigned this May 19, 2023
@atc0005 atc0005 merged commit f3388e5 into master May 19, 2023
@atc0005 atc0005 deleted the fix-revive-linting-errors branch May 19, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@atc0005