Fix TestPerformanceDataIsNotDuplicated test #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test began failing with work on PR branch for PR-175 which expanded validation support for PerformanceData field values. The previous test metric values used words in place of expected field values: - literal "U" - character or values in the regex character class "[-0-9.]" This commit moves the self-documenting Value field strings to slice element comments and replaces them with placeholder numeric values which pass Value field validation. refs GH-175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test began failing with work on PR branch for PR-175 which expanded validation support for PerformanceData field values.
The previous test metric values used words in place of expected field values:
This commit moves the self-documenting Value field strings to slice element comments and replaces them with placeholder numeric values which pass Value field validation.
refs GH-175