Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename primary ExitState type to Plugin, New constructor to NewPlugin #169

Closed
atc0005 opened this issue Dec 15, 2022 · 0 comments · Fixed by #170
Closed

Rename primary ExitState type to Plugin, New constructor to NewPlugin #169

atc0005 opened this issue Dec 15, 2022 · 0 comments · Fixed by #170
Assignees
@atc0005
Labels
breaking documentation Improvements or additions to documentation tests
Milestone
v0.12.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Dec 15, 2022

Instead of duplicating code in order to provide deprecation of the ExitState, replace it directly with a Plugin type.

Because (as of this writing) pkg.go.dev and GitHub do not show any other projects using this code (aside from projects that I currently maintain), this is a relatively safe breaking change to make.

CI jobs will flag breakage for dependent projects so that I can pair client code changes with merging in a PR containing these changes.
@atc0005 atc0005 added documentation Improvements or additions to documentation breaking config labels Dec 15, 2022
@atc0005 atc0005 added this to the Next Release milestone Dec 15, 2022
@atc0005 atc0005 self-assigned this Dec 15, 2022
atc0005 added a commit that referenced this issue Dec 15, 2022
@atc0005
Rename ExitState type to Plugin
0cb711a 
Rename the type and update all references to it. Doc changes
have been applied also, though with a change like this one it
is possible I missed a reference somewhere.

refs GH-169
@atc0005 atc0005 added tests and removed config labels Dec 15, 2022
@atc0005 atc0005 mentioned this issue Dec 15, 2022
Merged
atc0005 added a commit that referenced this issue Dec 15, 2022
@atc0005
Rename ExitState to Plugin, New func to NewPlugin
e684ceb 
- rename the type and update all references to it
- rename the New constructor to NewPlugin, update all
  references to it

Doc changes have been applied also, though it is possible I
missed a reference somewhere.

refs GH-169
@atc0005 atc0005 changed the title Rename primary ExitState type to Plugin Rename primary ExitState type to Plugin, New constructor to NewPlugin Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
breaking documentation Improvements or additions to documentation tests
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Rename ExitState to Plugin, New func to NewPlugin atc0005/go-nagios
1 participant
@atc0005